[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: cleanup tap devices on FreeBSD



On Wed, Feb 26, 2014 at 09:12:11AM -0700, Eric Blake wrote:
> On 02/26/2014 08:57 AM, Roman Bogorodskiy wrote:
> >>
> >> Conceptually ok, but I fear this impl will result in the logs getting
> >> polluted with "cannot delete tap device" or similar log messages on OS
> >> where TAP device deletion is automatic.
> > 
> > Do you have an idea about better way to do that?
> 
> Maybe add a boolean parameter that says whether the function should be
> quiet to avoid log noise, where the default is noisy but this cleanup
> path is quiet.

Or just make it #ifdef BSD, or call virNetDevExists() to check it ?

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]