[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 4/4] add dump_memory_format in qemu.conf



On 02/27/2014 08:55 AM, Daniel P. Berrange wrote:
>> Arguably, if you support value '0' as an explicit "use the default
>> format from the .conf file", and '1' as "raw", then you could set it up
>> so that applications have explicit control over all formats when
>> desired, but can use the .conf file default when they don't care.  But
>> again, this would have to be explicit by having an enum value in the .h
>> file that explicitly states the user wants to use a .conf file setting
>> (without regards to its value) instead of their own explicit value.
> 
> While you could do that, I just don't see the value in having an option
> where the data you get back is in an arbitrary format you can't predict

If we support this mode, then the return value has to be the enum value
of what format was actually chosen, rather than a simpler -1/0 return.

The more complex this sounds, the more I like Dan's preference for
simpler usage.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]