[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 6/8] Include error domain and code in log messages from errors



On 02/24/2014 09:49 AM, Daniel P. Berrange wrote:
> When a virError is raised, pass the error domain and code
> onto the systemd journald using metadata fields.
> 
> This allows error messages to be queried by code eg
> 
>   $ journalctl LIBVIRT_CODE=43

Requires the user to do a reverse lookup from the header file, but as we
have declared our public error enums as stable, it's not going to
change, so this is reasonable.

> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  docs/logging.html.in | 4 ++++
>  src/util/virerror.c  | 8 +++++++-
>  2 files changed, 11 insertions(+), 1 deletion(-)
> 

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]