[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] tests: virnetsockettest: Print the error if getifaddrs fails.



On 01/01/2014 08:49 AM, Richard W.M. Jones wrote:
> From: "Richard W.M. Jones" <rjones redhat com>
> 
> ---
>  tests/virnetsockettest.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/virnetsockettest.c b/tests/virnetsockettest.c
> index eda95bc..82c202e 100644
> --- a/tests/virnetsockettest.c
> +++ b/tests/virnetsockettest.c
> @@ -60,8 +60,10 @@ checkProtocols(bool *hasIPv4, bool *hasIPv6,
>      *hasIPv4 = *hasIPv6 = false;
>      *freePort = 0;
>  
> -    if (getifaddrs(&ifaddr) < 0)
> +    if (getifaddrs(&ifaddr) < 0) {
> +        perror ("getifaddrs");
>          goto cleanup;
> +    }

ACK.  Doesn't change pass/fail status, but makes debugging failure nicer.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]