[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/3] tests: sysinfotest: Actual/expected were swapped in error message.



On 01/01/2014 08:49 AM, Richard W.M. Jones wrote:
> From: "Richard W.M. Jones" <rjones redhat com>
> 
> ---
>  tests/sysinfotest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/sysinfotest.c b/tests/sysinfotest.c
> index 8357701..c8675f9 100644
> --- a/tests/sysinfotest.c
> +++ b/tests/sysinfotest.c
> @@ -83,7 +83,7 @@ testSysinfo(const void *data)
>          goto cleanup;
>  
>      if (STRNEQ(sysfsActualData, sysfsExpectData)) {
> -        virtTestDifference(stderr, sysfsActualData, sysfsExpectData);
> +        virtTestDifference(stderr, sysfsExpectData, sysfsActualData);

ACK.  A quick:
 git grep virtTestDiff'.*,.*ctual.*,' tests/
didn't turn up any other obvious swaps (but not all tests use the same
naming, so that's not conclusive)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]