[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/24] maint: improve debug of libvirt-{qemu, lxc} apis




On 12/28/2013 11:11 AM, Eric Blake wrote:
> I noticed that the virDomainQemuMonitorCommand debug output wasn't
> telling me the name of the domain it was working on.  While it was
> easy enough to determine which pointer matches the domain based on
> other log messages, it is nicer to be consistent.
> 
> * src/util/viruuid.h (VIR_UUID_DEBUG): Moved here from...
> * src/libvirt.c (VIR_UUID_DEBUG): ...here.
> (VIR_ARG15, VIR_HAS_COMMA, VIR_DOMAIN_DEBUG_EXPAND)
> (VIR_DOMAIN_DEBUG_PASTE, VIR_DOMAIN_DEBUG_0, VIR_DOMAIN_DEBUG_1)
> (VIR_DOMAIN_DEBUG_2, VIR_DOMAIN_DEBUG): Move...
> * src/datatypes.h: ...here.
> * src/libvirt-qemu.c (virDomainQemuMonitorCommand)
> (virDomainQemuAgentCommand): Better debug messages.
> * src/libvirt-lxc.c (virDomainLxcOpenNamespace): Likewise.
> 
> Signed-off-by: Eric Blake <eblake redhat com>
> ---
>  src/datatypes.h    | 60 ++++++++++++++++++++++++++++++++++++++++++++-
>  src/libvirt-lxc.c  |  4 +--
>  src/libvirt-qemu.c | 11 +++++----
>  src/libvirt.c      | 71 ------------------------------------------------------
>  src/util/viruuid.h | 20 ++++++++++++++-
>  5 files changed, 86 insertions(+), 80 deletions(-)
> 

Seems to follow what Daniel suggested.

ACK


John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]