[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 16/24] maint: improve VIR_ERR_INVALID_STORAGE_POOL usage




On 12/28/2013 11:11 AM, Eric Blake wrote:
> virStoragePoolBuild reported an invalid pool as if it were an
> invalid network.  Likewise, we weren't consistent on whether to
> use VIR_FROM_NONE or VIR_FROM_STORAGE.  Similar to previous
> patches, use a common macro to make it nicer.  For now, we
> don't need virCheckStoragePoolGoto().
> 
> * src/datatypes.h (virCheckStoragePoolReturn): New macro.
> (VIR_IS_STORAGE_POOL, VIR_IS_CONNECTED_STORAGE_POOL): Drop
> unused macros.
> * src/libvirt.c: Use macro throughout.
> (virLibStoragePoolError): Drop unused macro.
> 
> Signed-off-by: Eric Blake <eblake redhat com>
> ---
>  src/datatypes.h |  17 ++++--
>  src/libvirt.c   | 172 +++++++++++++-------------------------------------------
>  2 files changed, 51 insertions(+), 138 deletions(-)
> 

Same as previous w/r/t connection required for GetName, GetUUID, and
GetUUIDString

ACK

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]