[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 22/24] maint: improve VIR_ERR_INVALID_DOMAIN_SNAPSHOT usage




On 12/28/2013 11:11 AM, Eric Blake wrote:
> The existing check of domain snapshots validated that they
> point to a domain, but did not validate that the domain
> points to a connection, even though any errors blindly assume
> the connection is valid.  For consistency with previous
> patches, continue the trend of using a common macro.  For
> now, we don't need virCheckDomainSnapshotGoto().
> 
> * src/datatypes.h (virCheckDomainSnapshotReturn): New macro.
> (VIR_IS_SNAPSHOT, VIR_IS_DOMAIN_SNAPSHOT):
> Drop unused macros.
> * src/libvirt.c: Use macro throughout.
> (virLibDomainSnapshotError): Drop unused macro.
> 
> Signed-off-by: Eric Blake <eblake redhat com>
> ---
>  src/datatypes.h |  18 +++++++--
>  src/libvirt.c   | 118 +++++++++++---------------------------------------------
>  2 files changed, 36 insertions(+), 100 deletions(-)
> 

ACK

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]