[libvirt] [PATCH 11a/2] event [squash with next]: test per-domain events of offline domain

Eric Blake eblake at redhat.com
Sat Jan 4 14:00:34 UTC 2014


Done as a separate patch from 11/2 so that I can prove it flushes
out the flaw; but will be squashed when I push.

* tests/objecteventtest.c (testDomainCreateXMLMixed): Enhance test.
---
 tests/objecteventtest.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tests/objecteventtest.c b/tests/objecteventtest.c
index adcf0d5..49a50c8 100644
--- a/tests/objecteventtest.c
+++ b/tests/objecteventtest.c
@@ -223,7 +223,7 @@ testDomainCreateXMLMixed(const void *data)
     /* Fun with mixing old and new API, also with global and
      * per-domain.  Handler should be fired three times, once for each
      * registration.  */
-    dom = virDomainCreateXML(test->conn, domainDef, 0);
+    dom = virDomainDefineXML(test->conn, domainDef);
     if (dom == NULL)
         goto cleanup;

@@ -233,8 +233,6 @@ testDomainCreateXMLMixed(const void *data)
                                            &counter, NULL);
     if (id1 < 0)
         goto cleanup;
-    if (virDomainDestroy(dom) < 0)
-        goto cleanup;
     if (virConnectDomainEventRegister(test->conn,
                                       domainLifecycleCb,
                                       &counter, NULL) != 0)
-- 
1.8.4.2




More information about the libvir-list mailing list