[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] Add GVirConfigDomainDiskDriver



On 06.12.2013 12:13, Christophe Fergeau wrote:
> Hey,
> 
> I wanted to add support in libvirt-gconfig for the 'discard' attribute of
> the disk driver node.  If I follow the way the API is currently done, it
> would be an additional method to GVirConfigDomainDisk. However, there are
> quite a few attributes attached to the disk driver node, so I felt it was
> preferrable to have a dedicated GVirConfigDomainDiskDriver class. This also
> matches better other places of libvirt-gconfig API.
> I've implemented support for most of the attributes of the disk driver node,
> as a result the corresponding methods in GVirConfigDomainDisk have been deprecated.
> 
> Christophe
> 

It's been a while since the last time I've written something for
libivrt-glib. So just my two cents: I'd say go with new class esp. if
there's a chance for attributes to expand. Although, we still have to
maintain the old APIs to set some driver attributes directly - I guess
there's no way of deprecating/dropping those APIs right?

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]