[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/2] event: use newer array management macros




On 01/03/2014 04:11 PM, Eric Blake wrote:
> We might as well take advantage of viralloc.h instead of open-coding
> array management ourselves.  While at it, I simplified several
> places that were doing repetitive pointer chasing to use an
> intermediate variable for legibility (some other places remain,
> but they will disapper in later refactoring patches).
> 
> * src/conf/object_event_private.h (_virObjectEventCallbackList):
> Use size_t for count.
> * src/conf/object_event.c (_virObjectEventQueue): Likewise.
> (virObjectEventCallbackListRemoveID): Use VIR_DELETE_ELEMENT.
> (virObjectEventQueuePush, virObjectEventCallbackListAddID): Use
> VIR_APPEND_ELEMENT.
> (virObjectEventCallbackListEventID)
> (virObjectEventStateDispatchCallbacks): Simplify code.
> 
> Signed-off-by: Eric Blake <eblake redhat com>
> ---
>  src/conf/object_event.c         | 108 ++++++++++++++++------------------------
>  src/conf/object_event_private.h |   2 +-
>  2 files changed, 44 insertions(+), 66 deletions(-)
> 

ACK


John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]