[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/2] event: add test of old-style events



On 01/06/2014 07:27 AM, John Ferlan wrote:

> I've only been able to apply up thru patch 5/5a... patch 2 didn't apply
> as well:
> 
> Applying: event: make deregister return value match docs
> error: patch failed: src/lxc/lxc_driver.c:1
> error: src/lxc/lxc_driver.c: patch does not apply
> error: patch failed: src/xen/xen_driver.c:1
> error: src/xen/xen_driver.c: patch does not apply
> Patch failed at 0001 event: make deregister return value match docs
> 
> Skipping 2, I was able to apply 3, 4, 5, & 5a before 6 failed as well.
> 
> In any case, this patch failed to build due to an uninitialized 'dom' in
> the new function and the changed one (since there's now a goto before
> dom gets initialized).
> 
> After inserting a couple of dom = NULL; - I had a core, I now assume the
> core had to do with patch 2.
> 
> I think perhaps it'd be better to rebase and repost 2->12.

Indeed.  I'll repost the rest of the series after applying ACKd patches.
 This series is a prereq to a fix for a CVE still under embargo, where I
hope to have the CVE squashed in time for the 1.2.1 release.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]