[libvirt] [PATCHv2 00/14] event cleanups

Eric Blake eblake at redhat.com
Mon Jan 6 22:27:15 UTC 2014


I'm sitting on quite a few event fixes, prior to being able
to reach my goal of adding a new api to libvirt-qemu.so for
querying arbitrary monitor events.

For testing purposes, I split the tests from the code changes,
to make it easier (at least for me) to prove what the bugs are,
and how the code fixes the bug.  Each patch in this series
should pass 'make', but those labeled '[squash with next]'
will fail 'make check' until you also apply the next patch in
the series.  Before pushing, I will merge the patches as
documented.  That is, although there are 14 mails, there are
only 9 commits to push when I finally get acks.  If you
exclude tests/, this series removes more lines than it adds
(always a desirable goal when refactoring to fix bugs).

Eric Blake (14):
  event [squash with next]: add test of old-style events
  event: make deregister return value match docs
  event [squash with next]: test shared state driver in test:///default
  event: share state driver between test:///default connections
  event: rename confusing variable in test, remote drivers
  event [squash with next]: test that old-style can't clobber new-style
  event: don't let old-style events clobber per-domain events
  event: tighten scope of object_event
  event: properly filter count of remaining events
  event [squash with  next]: test that old-style is distinct from
    new-style
  event: don't allow mix of old- and new-style registration
  event [squash with next]: test per-domain events of offline domain
  event: don't turn offline domain into global event
  event: make network events easier to use without casts

 src/conf/domain_event.c         | 185 ++++-------------------------
 src/conf/network_event.c        |  16 +--
 src/conf/network_event.h        |   3 +-
 src/conf/object_event.c         | 255 +++++++++++++++++++++++++++++-----------
 src/conf/object_event.h         |   5 +-
 src/conf/object_event_private.h |  63 ++--------
 src/libvirt.c                   |  17 ++-
 src/libxl/libxl_driver.c        |  35 +++---
 src/lxc/lxc_driver.c            |  30 ++---
 src/network/bridge_driver.c     |  14 ++-
 src/remote/remote_driver.c      |  86 ++++++--------
 src/test/test_driver.c          | 135 +++++++++++++--------
 src/uml/uml_driver.c            |  29 +++--
 src/vbox/vbox_tmpl.c            |  32 +++--
 src/xen/xen_driver.c            |  25 ++--
 tests/objecteventtest.c         | 196 +++++++++++++++++++++++++++---
 16 files changed, 631 insertions(+), 495 deletions(-)

-- 
1.8.4.2




More information about the libvir-list mailing list