[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] libxl: Fix initialization of nictype in libxl_device_nic



Eric Blake wrote:
> On 01/06/2014 11:59 AM, Jim Fehlig wrote:
>   
>> As pointed out by the Xen folks [1], HVM nics should always be set
>> to type LIBXL_NIC_TYPE_VIF_IOEMU unless the user explicity requests
>> LIBXL_NIC_TYPE_VIF via model='netfront'.  The current logic in
>> libxlMakeNic() only sets the nictype to LIBXL_NIC_TYPE_VIF_IOEMU if
>> a model is specified that is not 'netfront', which breaks PXE booting
>> configurations where no model is specified (i.e. use the hypervisor
>> default).
>>
>>   Reported-by: Stefan Bader <stefan bader canonical com>
>>
>> [1] https://www.redhat.com/archives/libvir-list/2013-December/msg01156.html
>>
>> Signed-off-by: Jim Fehlig <jfehlig suse com>
>> ---
>>
>> I toyed with detecting whether to use an IOEMU nic in libxlMakeNicList()
>> and passing the bool to libxlMakeNic(), but in the end left the detection
>> to libxlMakeNic().
>>     
>
> Seems okay to me with the approach you took.
>
>   
>>  src/libxl/libxl_conf.c | 20 ++++++++++++++------
>>  src/libxl/libxl_conf.h |  4 +++-
>>  2 files changed, 17 insertions(+), 7 deletions(-)
>>     
>
> ACK.
>   

Thanks, pushed.

Regards,
Jim


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]