[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix argument order at qemuMigrationPerformJob().



On 01/07/2014 02:03 AM, Minoru Usui wrote:
> Hi, everyone.
> 
> I found a small bug at qemuMigrationPerformJob().
> The order of argument, @listenAddress and @cookiein, should be changed place,
> because these order are mismatched caller and callee.
> 
> Signed-off-by: Minoru Usui <usui mxm nes nec co jp>
> ---
>  src/qemu/qemu_migration.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

ACK.

This breaks the use of listen address for p2p migration and ignores the input
cookie for migration protocols older than v3.

Introduced along with the listen address parameter in
c4ac7ef (describe --contains: v1.1.4-rc1~141).

Jan

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]