[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemuStateInitialize: Create qemu log directory



On 01/07/2014 06:21 AM, Michal Privoznik wrote:

> I think we need a different approach here. The error is overwritten in
> qemuProcessStop(). And I think that's the actual place, that needs to be
> fixed:
> 
> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
> index d0fde54..9331744 100644
> --- a/src/qemu/qemu_process.c
> +++ b/src/qemu/qemu_process.c
> @@ -4224,6 +4224,10 @@ void qemuProcessStop(virQEMUDriverPtr driver,
>          return;
>      }
> 
> +    /* This method is routinely used in clean up paths. Disable error
> +     * reporting so we don't squash a legit error. */
> +    orig_err = virSaveLastError();
> +


Indeed, this code motion looks nicer.  ACK to turning it into a formal
patch.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]