[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 08/14] event: tighten scope of object_event




On 01/06/2014 05:27 PM, Eric Blake wrote:
> Tighten up scope after the previous patch avoided using
> internals.  This will also make it easier to change
> internal implementation without having to chase down quite
> as many impacted callers or worrying about two files getting
> implementations out of sync.
> 
> * src/conf/object_event_private.h
> (virObjectEventCallbackListAddID, virObjectEventQueueClear)
> (virObjectEventStateLock, virObjectEventStateUnlock)
> (virObjectEventTimer): Drop prototype.
> (_virObjectEventCallbackList, _virObjectEventState)
> (_virObjectEventCallback): Move...
> * src/conf/object_event.c: ...here.
> (virObjectEventCallbackListAddID, virObjectEventQueueClear)
> (virObjectEventStateLock, virObjectEventStateUnlock)
> (virObjectEventTimer): Mark private.
> 
> Signed-off-by: Eric Blake <eblake redhat com>
> ---
>  src/conf/object_event.c         | 42 +++++++++++++++++++++++++----
>  src/conf/object_event_private.h | 58 -----------------------------------------
>  2 files changed, 37 insertions(+), 63 deletions(-)
> 

ACK

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]