[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 07/14] event: don't let old-style events clobber per-domain events



On 01/07/2014 08:24 AM, Eric Blake wrote:
> On 01/07/2014 08:14 AM, John Ferlan wrote:
>>
>>
> 
>>> Signed-off-by: Eric Blake <eblake redhat com>
>>> ---
>>>  src/conf/domain_event.c         | 171 ++++------------------------------------
>>>  src/conf/object_event.c         |  96 +++++++++++++++++++---
>>>  src/conf/object_event_private.h |   9 +++
>>>  3 files changed, 109 insertions(+), 167 deletions(-)
>>>
>>
>> ACK the pair (6 & 7)... The intro comment to 6 had me do a double take
>> though thinking I messed up the pair!
> 
> Oops :)  - I forgot to touch that up when submitting the series (you can
> tell which order I wrote the series, and then I rebased before posting
> it, and rebased again to get my merged patches that I'm actually
> pushing).  At any rate, I'll be pushing this soon.  Thanks for the review.

Then I promptly broke the patch while merging the two together, and had
to commit a one-line fixup patch.  Oh well, bisection is broken if you
hit my mistake (serves me right for not waiting for 'make check' to
complete...)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]