[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH ruby-libvirt v2] Don't free more entries than we retrieved



On Tue, Jan 07, 2014 at 08:55:04PM -0500, Chris Lalancette wrote:
> On Tue, Jan 7, 2014 at 4:54 PM, Guido Günther <agx sigxcpu org> wrote:
> > The vir*List* functions return the number of fetched entries. We mustn't
> > free more, otherwise we'll crash like
> >
> >  #0  0xb779d424 in __kernel_vsyscall ()
> >  #1  0xb733981f in __GI_raise (sig=sig entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
> >  #2  0xb733ccd3 in __GI_abort () at abort.c:90
> >  #3  0xb7376275 in __libc_message (do_abort=do_abort entry=2, fmt=fmt entry=0xb74767d0 "*** Error in `%s': %s: 0x%s ***\n") at ../sysdeps/unix/sysv/linux/libc_fatal.c:199
> >  #4  0xb7380e52 in malloc_printerr (action=<optimized out>, str=<optimized out>, ptr=0xb7087000) at malloc.c:4923
> >  #5  0xb7381b90 in _int_free (av=0xb74b7440 <main_arena>, p=0xb7086ff8, have_lock=0) at malloc.c:3779
> >  #6  0xb75c059f in ruby_xfree () from /usr/lib/libruby-1.9.1.so.1.9
> >  #7  0xb7076448 in ruby_libvirt_generate_list () from /usr/lib/ruby/vendor_ruby/1.9.1/i486-linux/_libvirt.so
> > ...
> >
> > since we're trying to free random addresses.
> 
> Thanks, I've applied this patch now.  This is probably worthy of

Thanks!

> another release, since it could be quite a bad bug.  That being said,
> are you actively doing additional testing?  If so, I'll wait a bit
> longer to see if you come up with anything else.

Unfortunately I won't have time to work more on this during the next
days. I plan to run more time during Debian package builds in the future
but this will have to wait for a bit more free time.
Cheers,
 -- Guido


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]