[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] test driver: Add authentication to test driver.



On Wed, Jan 08, 2014 at 12:33:20PM -0700, Eric Blake wrote:
> > +    username = virAuthGetUsername(conn, auth, "test", NULL, "localhost"/*?*/);
> 
> Is the /*?*/ intentional?

It's intentionally a question :-)

The virAuthGetUsername is demanding that I pass a non-null hostname
here.  I don't have a non-null hostname.  conn->uri->server is the
closest thing, but in the test driver that would always be NULL (it
might be non-NULL if visiting the test driver via the remote driver,
but this code is on the wrong side of the connection).

However this does not particularly matter.  virAuthGetUsername just
uses in a message for the user.

v2 patch coming up shortly.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]