[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 15/24] maint: improve VIR_ERR_INVALID_INTERFACE usage



On 01/02/2014 05:19 PM, John Ferlan wrote:
> 
> 
> On 12/28/2013 11:11 AM, Eric Blake wrote:
>> When checking for a valid interface, we weren't consistent on
>> whether ew reported as VIR_FROM_NONE or VIR_FROM_INTERFACE.

s/ew/we/

>> Similar to previous patches, use a common macro to make it nicer.
>> For now, we don't need virCheckInterfaceGoto().
>>
>> * src/datatypes.h (virCheckInterfaceReturn): New macro.
>> (VIR_IS_INTERFACE, VIR_IS_CONNECTED_INTERFACE): Drop unused
>> macros.
>> * src/libvirt.c: Use macro throughout.
>> (virLibInterfaceError): Drop unused macro.
>>
>> Signed-off-by: Eric Blake <eblake redhat com>
>> ---
>>  src/datatypes.h | 17 +++++++++----
>>  src/libvirt.c   | 74 +++++++++++++++------------------------------------------
>>  2 files changed, 32 insertions(+), 59 deletions(-)
>>
> 
> Same concern as Networks - the virInterfaceGetName() and
> virInterfaceGetMACString() will require a connection...

And same response - I touched up the commit message to explain it better.

> 
> ACK

Pushed.


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]