[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 17/24] maint: improve VIR_ERR_INVALID_STORAGE_VOL usage



On 01/02/2014 05:28 PM, John Ferlan wrote:
> 
> 
> On 12/28/2013 11:11 AM, Eric Blake wrote:
>> For storage volume validation, we weren't consistent on
>> whether to use VIR_FROM_NONE or VIR_FROM_STORAGE.  Similar
>> to previous patches, use a common macro to make it nicer.
>>
>> virStorageVolCreateXMLFrom allows cross-connection cloning,
>> where the error is reported against the connection of the
>> destination pool.
>>
>> * src/datatypes.h (virCheckStorageVolReturn)
>> (virCheckStorageVolGoto): New macros.
>> (VIR_IS_STORAGE_VOL, VIR_IS_CONNECTED_STORAGE_VOL): Drop
>> unused macros.
>> * src/libvirt.c: Use macro throughout.
>> (virLibStorageVolError): Drop unused macro.
>>
>> Signed-off-by: Eric Blake <eblake redhat com>
>> ---
>>  src/datatypes.h |  29 +++++++++++++--
>>  src/libvirt.c   | 112 ++++++++++++--------------------------------------------
>>  2 files changed, 49 insertions(+), 92 deletions(-)
>>
> 
> Same as previous w/r/t GetName and GetKey here.
> 
> ACK

Same response; I improved the commit message before pushing.


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]