[libvirt] [PATCH 18/24] maint: improve VIR_ERR_INVALID_NODE_DEVICE usage

Eric Blake eblake at redhat.com
Thu Jan 9 18:31:34 UTC 2014


On 01/02/2014 05:30 PM, John Ferlan wrote:
> 
> 
> On 12/28/2013 11:11 AM, Eric Blake wrote:
>> While all errors related to invalid node device appeared to be
>> consistent, we might as well continue the trend of using a
>> common macro.  For now, we don't need virCheckNodeDeviceGoto().
>>
>> * src/datatypes.h (virCheckNodeDeviceReturn): New macro.
>> (VIR_IS_NODE_DEVICE, VIR_IS_CONNECTED_NODE_DEVICE): Drop
>> unused macros.
>> * src/libvirt.c: Use macro throughout.
>> (virLibNodeDeviceError): Drop unused macro.
>>
>> Signed-off-by: Eric Blake <eblake at redhat.com>
>> ---
>>  src/datatypes.h | 17 +++++++++---
>>  src/libvirt.c   | 83 ++++++++++-----------------------------------------------
>>  2 files changed, 27 insertions(+), 73 deletions(-)
>>
> 
> 
> ACK

Pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140109/4d05a396/attachment-0001.sig>


More information about the libvir-list mailing list