[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 20/24] maint: improve VIR_ERR_INVALID_STREAM usage



On 01/02/2014 05:51 PM, John Ferlan wrote:
> 
> 
> On 12/28/2013 11:11 AM, Eric Blake wrote:
>> For streams validation, we weren't consistent on whether to
>> use VIR_FROM_NONE or VIR_FROM_STREAMS.  Furthermore, in
>> many API, we want to ensure that a stream is tied to the
>> same connection as the other object we are operating on;
>> while other API failed to validate the stream at all.
>> Similar to previous patches, use a common macro to make it
>> nicer.
>>
>> * src/datatypes.h (virCheckStreamReturn, virCheckStreamGoto):
>> New macros.
>> (VIR_IS_STREAM, VIR_IS_CONNECTED_STREAM): Drop unused macros.
>> * src/libvirt.c: Use macro throughout.
>> (virLibStreamError): Drop unused macro.
>>
>> Signed-off-by: Eric Blake <eblake redhat com>
>> ---
>>  src/datatypes.h |  29 +++++++++++--
>>  src/libvirt.c   | 128 ++++++++++++++++++++++----------------------------------
>>  2 files changed, 76 insertions(+), 81 deletions(-)
>>
> 
> ACK
> 
> virDomainOpenConsole certainly assumed things previously!

Which means this is a bug fix, so I'm justified for pushing it after the
freeze :)  When I first discovered it, I tried hard to think of any
scenarios where it might be abused; I couldn't come up with any, which
is why I made the patch public, but I hope I didn't overlook any case
for abuse.  Now pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]