[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 22/24] maint: improve VIR_ERR_INVALID_DOMAIN_SNAPSHOT usage



On 01/02/2014 06:38 PM, John Ferlan wrote:
> 
> 
> On 01/02/2014 07:53 PM, John Ferlan wrote:
>>
>>
>> On 12/28/2013 11:11 AM, Eric Blake wrote:
>>> The existing check of domain snapshots validated that they
>>> point to a domain, but did not validate that the domain
>>> points to a connection, even though any errors blindly assume
>>> the connection is valid.  For consistency with previous
>>> patches, continue the trend of using a common macro.  For
>>> now, we don't need virCheckDomainSnapshotGoto().
>>>

>>
>> Still paying attention (barely)... GetName, GetUUID, and GetUUIDString
>> will all now require the connection

Again intentional, so updated the commit message to mention it.

>>
> 
> Guess I wasn't paying that close attention as this was meant for 21/24 :-)
> 
> John
> 
>>
>> ACK

21 is now pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]