[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 06/10] snapshot: Test snapshot disk type specification



On 01/09/2014 09:15 AM, Peter Krempa wrote:
> Amend tests to check parsing of the various new disk types that can now
> be specified.
> ---
>  tests/domainsnapshotxml2xmlin/disk_snapshot.xml  | 18 ++++++++++++++++++
>  tests/domainsnapshotxml2xmlout/disk_snapshot.xml | 18 ++++++++++++++++++
>  2 files changed, 36 insertions(+)

...Ah, this was what I was looking for in 5/10.  I guess it's okay as
separate patches, to keep review size down.

> +    <disk name='hdh' snapshot='external' type='network'>

Wow - that VM has lots of disks :)

ACK to this patch, but obviously it has to be applied as part of the series.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]