[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 08/10] storage: gluster: Support conversion of gluster volumes to temp volumes



On 01/09/2014 09:15 AM, Peter Krempa wrote:
> Add code to convert an regular guest volume into a ephemeral pool.

s/an regular/a regular/

> +
> +    if (VIR_STRDUP(volume, source) < 0)
> +        goto cleanup;
> +
> +    if ((tmp = strchr(volume, '/')))
> +        *tmp++ = '0';

'0'?  Don't you mean '\0'?


> +    if (backend->startPool &&
> +        backend->startPool(conn, pool) < 0) {
> +        virStoragePoolObjRemove(&driver->pools, pool);
> +        pool = NULL;
> +        goto cleanup;
> +    }
> +
> +    pool->active = 1;

Don't you also need to set the ephemeral bit?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]