[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 4/7] Add network events to the remote driver



On 12/12/2013 07:30 AM, Cedric Bosdonnat wrote:
> Hi John,
> 

>>> +    event = virNetworkEventLifecycleNew(net->name, net->uuid, msg->event);
>>> +    virNetworkFree(net);
>>> +    remoteDomainEventQueue(priv, event);

>> Essentially - you need to check for NULL event.
> 
> Sure, but the weird thing it that it should also complain on the similar
> functions for domain events, right above this one in the same file.

Revisiting this.  The problem can only happen on OOM situations, so it's
not that likely to hit in real life; but we should indeed fix our code.
 I think the easiest way is to fix remoteDomainEventQueue to gracefully
do nothing on a NULL event (events are best effort, and if OOM occurs,
skipping event delivery is an acceptable action, since we have no way of
reporting the error).  I'll post a patch.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]