[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Add support for changing timeout value to open unix monitor socket



On Mon, Dec 30, 2013 at 07:23:00PM +0200, Pavel Fux wrote:
> Hi,
> 
> I am talking about *Bug
> 987088*<https://bugzilla.redhat.com/show_bug.cgi?id=987088>,
> I have added a patch and a description of the fix, this is a copy of my
> comment on the bug:
> 
> the default code behavior is wait for 3 seconds and if the socket is not
> opened yet, print this error and terminate.
> 
> the code is in src/qemu/qemu_monitor.c in function qemuMonitorOpenUnix.
> 
> In 2009 there was a patch that added the original 3 seconds retry, the
> patch can be found here:
> 
> http://www.redhat.com/archives/libvir-list/2009-July/msg00335.html
> 
> I have added a patch with this solution:
> 
> the default behavior stays the same, but a user can add a configuration
> variable to qemu.conf and change the timeout value.
> 
> every system needs a different value according to their system
> configuration but anyway 3 seconds is not suitable for all cases.


I think this is an inappropriate configuration setting. If we need a longer
timeout then we should just use a longer timeout not require an admin to
wait to see if ther box is broken and then try to set a config param to
fix it.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]