[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix docs for PMWakeup/PMSuspend callback types



On 01/15/2014 12:28 AM, Claudio Bley wrote:
> s/is waken up/is woken up/
> 
> A registered PMSuspendCallback is called when the domain is suspended, not
> when it is woken up.
> 
> Signed-off-by: Claudio Bley <cbley av-test de>
> ---
> It's just a trivial fix, but I'd like some educated comment on the
> grammar fix. IMO it is correct, or is there a better way to express
> this?

ACK; as a native speaker, your patch sounds right.

> 
>  include/libvirt/libvirt.h.in |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
> index 018a5ce..5bdb2bc 100644
> --- a/include/libvirt/libvirt.h.in
> +++ b/include/libvirt/libvirt.h.in
> @@ -4849,7 +4849,7 @@ typedef void (*virConnectDomainEventTrayChangeCallback)(virConnectPtr conn,
>   *          always passes 0
>   * @opaque: application specified data
>   *
> - * This callback occurs when the guest is waken up.
> + * This callback occurs when the guest is woken up.

If you want an alternative wording:

This callback occurs when the guest is awakened.

But I don't care which of the two wordings you use.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]