[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] BSD: implement nodeGetCPUStats



  Daniel P. Berrange wrote:

> On Tue, Jan 14, 2014 at 12:47:20PM +0400, Roman Bogorodskiy wrote:
> > I had doubts how to implement that. Looks like the current
> > implementation is tied to Linux CPU metrics:
> > 
> >   user nice system idle iowait
> > 
> > That list is hardcoded into virsh-host.c. FreeBSD has a slightly
> > different set of metrics:
> > 
> >   user nice system intr idle
> > 
> > I.e. it's interrupt time instead of i/o time.
> 
> That's not a problem. Just define a new API constant for INTR and
> don't use the IOWAIT constant in your impl. No impl is required to
> support every single possible value.

I've just uploaded new version of the patch.

Meanwhile, I was thinking if it would be reasonable just to count INTR
as system load without introducing a new variable.

Roman Bogorodskiy


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]