[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] spice: expose the QEMU disable file transfer option




----- Original Message -----
> From: "Doug Goldstein" <cardoe cardoe com>
> To: "Francesco Romani" <fromani redhat com>
> Cc: libvir-list redhat com, "Francesco Romani" <fromani redhat com>
> Sent: Thursday, January 16, 2014 4:24:51 AM
> Subject: Re: [libvirt] [PATCH 2/2] spice: expose the QEMU disable file transfer option
> 
> On Jan 15, 2014, at 10:33 AM, Francesco Romani <fromani redhat com> wrote:
> > 
> > spice-server offers an API to disable file transfer messages
> > on the agent channel between the client and the guest.
> > This is supported in qemu through the disable-agent-file-xfer option.
> > 
> > This patch exposes this option to libvirt.
> > Adds a new element 'filetransfer', with one property,
> > 'filetransfer', which accepts a boolean setting.
> > Default is enabled.
> 
> Haven't reviewed the code but the commit message is wrong. The property is
> 'enable' from the schema change.

Indeed it is. I will fix the commit message(s), this glitch is a relic of past
revisions.

I'll submit another patchset soon, I'll leave some time to gather more comments.

Thanks for pointing this out,

-- 
Francesco Romani


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]