[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib] config: Fix typo preventing clock removal from a domain



On Thu, Jan 2, 2014 at 11:03 AM, Christophe Fergeau <cfergeau redhat com> wrote:
> On Fri, Dec 06, 2013 at 12:10:29PM +0100, Christophe Fergeau wrote:
>> Commit 1c8ce29 added a way to unset a GVirConfigDomainClock set on a
>> GVirConfigDomain by calling gvir_config_domain_set_clock() with a NULL
>> argument.
>> However, a typo in a g_return_if_fail precondition prevents this code from
>> ever being called: g_return_if_fail(clock != NULL) is used while it should
>> have been g_return_if_fail(clock == NULL) as in all other preconditions in
>> 1c8ce29.

ACK

Zeeshan Ali (Khattak)
FSF member#5124


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]