[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/9] pci: Fix failure paths in detach



On 17.01.2014 11:39, Jiri Denemark wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1046919
> 
> Since commit v0.9.0-47-g4e8969e (released in 0.9.1) some failures during
> device detach were reported to callers of virPCIDeviceBindToStub as
> success. For example, even though a device seemed to be detached
> 
>     virsh # nodedev-detach pci_0000_07_05_0 --driver vfio
>     Device pci_0000_07_05_0 detached
> 
> one could find similar message in libvirt logs:
> 
>     Failed to bind PCI device '0000:07:05.0' to vfio-pci: No such device
> 
> This patch fixes these paths and also avoids overwriting real errors
> with errors encountered during a cleanup phase.
> 
> Signed-off-by: Jiri Denemark <jdenemar redhat com>
> ---
>  src/util/virpci.c | 39 +++++++++++++++++++++++----------------
>  1 file changed, 23 insertions(+), 16 deletions(-)

ACK

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]