[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-sandbox PATCH v3] Add filter support.



On Fri, Jan 17, 2014 at 04:29:37PM -0800, Ian Main wrote:
> On Thu, Jan 09, 2014 at 12:19:52PM +0100, Christophe Fergeau wrote:
> > Hey,
> > 
> > Wouldn't something like the patch below help to remove the code duplication
> > in libvirt-sandbox-config-builder-{container,machine}.c ?
> > 
> > Christophe
> 
> Yes, definitely.  My thinking was that the whole builder section should
> be gone over as there is still lots of duplicate code in there even with
> this patch.

I haven't looked very carefully for duplication, the code related to network interface was
at least different enough not to look duplicated. Even if there is
preexisting duplication, it's better to try to avoid adding more ;)


Christophe

Attachment: pgptUpH2xs6g0.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]