[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] Make syntax check notice assignments w/o surrounding spaces.



On Mon, Jan 20, 2014 at 12:27:28PM +0100, Thorsten Behrens wrote:
> ---
>  build-aux/bracket-spacing.pl | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/build-aux/bracket-spacing.pl b/build-aux/bracket-spacing.pl
> index 802a640..fd7438e 100755
> --- a/build-aux/bracket-spacing.pl
> +++ b/build-aux/bracket-spacing.pl
> @@ -144,6 +144,14 @@ foreach my $file (@ARGV) {
>              $ret = 1;
>              last;
>          }
> +
> +        # Require spaces around assignment '=' and compounds
> +        while ($data =~ /[^!<>&|\-+*\/%\^'= ]=[^=]/ ||
> +               $data =~ /[^!<>&|\-+*\/%\^'=]=[^= \\\n]/) {
> +            print "$file:$.: $line";
> +            $ret = 1;
> +            last;
> +        }
>      }
>      close FILE;
>  }
> --
> 1.8.4
>

This is great, although the syntax-check should be changed in the
second patch so that git bisect is not broken in one commit.  It'd be
also nice to make this check for '==' not having spaves around itself,
but I'm not sure we have that requirement specified anywhere, so it's
ok for now, I guess.

ACK if that goes as a second patch and git bisect is not broken.

Martin

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]