[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [RFC PATCH 6/7] configure: Add config driver to configure script



On 12/21/13 05:03, Adam Walters wrote:
> This conditionally enables compilation of the config driver based on if we are building libvirtd or not. Since this is only needed for hypervisor modules during libvirtd startup, we don't need to bother compiling the config driver when only building the client.
> 
> Signed-off-by: Adam Walters <adam pandorasboxen com>
> ---
>  configure.ac | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/configure.ac b/configure.ac
> index ddbcc8e..4834c51 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1606,6 +1606,16 @@ if test "$with_secrets" = "yes" ; then
>  fi
>  AM_CONDITIONAL([WITH_SECRETS], [test "$with_secrets" = "yes"])
>  
> +if test "$with_libvirtd" = "no" ; then
> +  with_config=no
> +else
> +  with_config=yes
> +fi
> +if test "$with_config" = "yes" ; then
> +    AC_DEFINE_UNQUOTED([WITH_CONFIG], 1, [whether local config driver is enabled])
> +fi
> +AM_CONDITIONAL([WITH_CONFIG], [test "$with_config" = "yes"])
> +
>  
>  AC_ARG_WITH([storage-dir],
>    [AS_HELP_STRING([--with-storage-dir],
> 

This patch definitely needs to go after the makefile change, otherwise
the tree won't be buildable after this patch. Also you may want to
squash it with the makefile changes.

Also the configure script contains a section outputting the config
summary at the bottom of configure.ac where you need to add a
corresponding entry for the new driver.

Peter

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]