[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 2/2] qemu: snapshot: Avoid libvirtd crash when qemu crashes while snapshotting



On 01/20/14 19:03, Eric Blake wrote:
> On 01/20/2014 10:09 AM, Peter Krempa wrote:
>> We shouldn't access the domain definition while we are in the monitor
>> section as the domain is unlocked. Additionaly after we exit from the
> 
> s/Additionaly/Additionally/
> 
>> monitor we need to check if the VM is still alive. Not doing so resulted
>> into crash if qemu exits while attempting to do a external VM snapshot.
> 
> s/into/in a/
> 
>> ---
>>
>> Notes:
>>     Version 1 was reported to break locking of a VM but withoit enough data to reproduce/trace.
>>     Version 2:
>>     - changed some of the conditions so that proper cleanup paths are taken
>>     - fixed returned error value in case the job can't be entered
>>
>>  src/qemu/qemu_driver.c | 53 ++++++++++++++++++++++++++++++++++++++------------
>>  1 file changed, 41 insertions(+), 12 deletions(-)
>>
> 
> Code looks correct, I also ran through a smoke test with your reproducer
> 1/2 applied, and confirmed that this code is definitely required for the
> fix.
> 
> ACK with grammar fixes.
> 

Thanks; pushed.

Peter

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]