[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [sec-notice PATCH 2/2] scripts: require bash for bashisms



On Tue, Jan 21, 2014 at 11:37:16AM -0700, Eric Blake wrote:
> Use of ${BASH_SOURCE[0]} is a syntax error in dash.
> Use of `` is pointless when we know we are in bash.
> 
> * scripts/lsn2text: Make more robust.
> * scripts/lsn2html: Likewise.
> * scripts/lsn2indexhtml: Likewise.
> * scripts/lsn2index: Likewise.
> 
> Signed-off-by: Eric Blake <eblake redhat com>
> ---
>  scripts/lsn2html      | 4 ++--
>  scripts/lsn2index     | 4 ++--
>  scripts/lsn2indexhtml | 4 ++--
>  scripts/lsn2text      | 4 ++--
>  4 files changed, 8 insertions(+), 8 deletions(-)

ACK, unless there's a better way to write it in general
shell without $BASE_SOURCE ?

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]