[libvirt] [PATCH v2]qemu:sheepdog correct OR to AND Permit qemu to access sheepdog volume on sheepdog's pool

Joel Simoes joel.simoes at laposte.net
Wed Jan 22 13:59:16 UTC 2014


I'm sleeping...
> From: root <joel.simoes at laposte.net>
>
> ---
>   src/qemu/qemu_conf.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
> index 7a0bee2..9cf2767 100644
> --- a/src/qemu/qemu_conf.c
> +++ b/src/qemu/qemu_conf.c
> @@ -1403,7 +1403,7 @@ qemuTranslateDiskSourcePool(virConnectPtr conn,
>       def->srcpool->pooltype = pooldef->type;
>       def->srcpool->voltype = info.type;
>   
> -    if ((def->srcpool->mode && pooldef->type != VIR_STORAGE_POOL_ISCSI) || (def->srcpool->mode != VIR_DOMAIN_DISK_SOURCE_POOL_MODE_DIRECT && pooldef->type == VIR_STORAGE_POOL_SHEEPDOG ) ) {
> +    if ((def->srcpool->mode && pooldef->type != VIR_STORAGE_POOL_ISCSI ) && (def->srcpool->mode != VIR_DOMAIN_DISK_SOURCE_POOL_MODE_DIRECT && pooldef->type == VIR_STORAGE_POOL_SHEEPDOG ) ) {
>           virReportError(VIR_ERR_XML_ERROR, "%s",
>                          _("disk source mode is only valid when "
>                            "storage pool is of iscsi type or only direct for sheepdog "));

Not work correctly. replace with case or else it's much...




More information about the libvir-list mailing list