[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 03/16] LXC from native: migrate fstab and lxc.mount.entry



On Tue, Jan 14, 2014 at 02:49:52PM +0100, Cédric Bosdonnat wrote:
> @@ -316,6 +568,38 @@ lxcParseConfigString(const char *config,
>      if (lxcSetRootfs(vmdef, properties) < 0)
>          goto error;
>  
> +    /* Look for fstab */
> +    if (!fstab) {
> +        char *fstabPath = NULL;
> +        if (VIR_STRDUP(fstabPath, virPropertiesLookup(properties, "lxc.mount")) < 0)
> +            goto error;
> +
> +        fstabEntries = lxcParseFstabFile(fstabPath);
> +        VIR_FREE(fstabPath);

I don't think this is going to fly for a couple of reasons. We can't
assume that the dir/file/block device referenced in the config exists
on the host we're doing the conversion on. If it is a block device
or a plain file, then you can't access the /etc/fstab inside it
either - you'd have to mount the filesystem first, which I don't 
think we want todo for this code.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]