[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] BSD: implement virProcess{Get,Set}Affinity



On 01/25/2014 09:11 AM, Roman Bogorodskiy wrote:
> Implement virProcess{Get,Set}Affinity() using cpuset_getaffinity()
> and cpuset_setaffinity() calls. Quick search showed that they are
> only available on FreeBSD, so placed it inside existing #ifdef
> blocks for FreeBSD instead of adding configure checks.

That's not the ideal approach.  Feature checking has the advantage that
if some other platform adds the feature in the future, then we
automatically start using it, even if FreeBSD is the only platform that
offers the feature right now.  However, the existing code really was
tied to just a FreeBSD check, so I could live with a followup that adds
the configure check in order to do a feature-based rather than
platform-based conditional compilation.

ACK and pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]