[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] virnetdevbandwidthtest: Introduce testVirNetDevBandwidthSet



On 01/27/2014 07:03 AM, Michal Privoznik wrote:
> The test tries to set some QoS limits and check if the commands
> that are actually executed are the expected ones.
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  tests/virnetdevbandwidthtest.c | 98 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 98 insertions(+)
> 

> +
> +    if (getenv("LIBVIRT_SKIP_CLEANUP") == NULL)
> +        unlink(outfile);
> +
> +    VIR_FORCE_CLOSE(outfile_fd);

Unlink before close may cause grief on mingw; close before unlink is
slightly more portable.  But it's nice to see that my idea worked for
testing this without needing an LD_PRELOAD mockup.  ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]