[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 3/4] Add a mutex to serialize updates to firewall



On 01/27/2014 10:18 AM, Daniel P. Berrange wrote:
> The nwfilter conf update mutex previously serialized
> updates to the internal data structures for firewall
> rules, and updates to the firewall itself. Since the
> former is going to be turned into a read/write lock
> instead of a mutex, a new lock is required to serialize
> access to the firewall itself.
> 
> With this new lock, the lock ordering rules will be
> for virNWFilter{Define,Undefine}
> 
>       1. nwfilter driver lock
>       2. nwfilter update lock
>       3. virt driver lock
>       4. domain object lock
>       5. gentech driver lock
> 
> and VM start
> 
>       1. nwfilter update lock
>       2. virt driver lock
>       3. domain object lock
>       4. gentech driver lock
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---

Is it worth adding a file describing the lock rules?  Comparable to
qemu/THREADS.txt?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]