[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 2/4] Remove windows thread implementation in favour of pthreads



On 01/28/2014 08:10 AM, Daniel P. Berrange wrote:
> On Mon, Jan 27, 2014 at 03:47:19PM -0700, Eric Blake wrote:
>> On 01/27/2014 10:18 AM, Daniel P. Berrange wrote:
>>> There are a number of pthreads impls available on Win32
>>> these days, in particular the mingw64 project has a good
>>> impl. Delete the native windows thread implementation and
>>> rely on using pthreads everywhere.
>>>
>>> Signed-off-by: Daniel P. Berrange <berrange redhat com>
>>> ---
>>
>> I'm still a bit worried about alienating F19 or RHEL.
> 
> So I tested on F19 with this series applied and hit a small problem
> 
>   CC       util/libvirt_util_la-viraudit.lo
> In file included from util/virstoragefile.h:28:0,
>                  from util/virfile.h:32,
>                  from util/viraudit.c:33:
> util/virutil.h:118:19: error: conflicting types for 'pthread_sigmask'
>  static inline int pthread_sigmask(int how,
>                    ^
> In file included from util/viraudit.c:27:0:
> ../gnulib/lib/signal.h:451:1: note: previous declaration of 'pthread_sigmask' was here
>  _GL_FUNCDECL_SYS (pthread_sigmask, int,
>  ^
> 

Okay, I'll fire up my F19 vm and resolve the issue (not sure yet if the
solution will require another gnulib submodule update...)


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]