[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 2/2] virsh: report only filled values in 'nodecpustats'



  Ján Tomko wrote:

> Maybe creating an enum with VIR_ENUM_DECL/VIR_ENUM_IMPL would make the code
> easier to read? (You could use the FromString/ToString functions and an array
> of bools to tell missing/zero fields apart instead of NULL pointers)

I'll try to play around with that approach. Although, it doesn't seem
that it would be _much_ more readable, but maybe I'm wrong.

> Hmm, did libvirtd ever fill out the 'usage' field? I can't find it in git history.
> 

IIRC, Daniel said it's provided for the systems that could not report a
detailed CPU info when I was asking what would be a proper way to
implement CPU stats on FreeBSD.

Meanwhile, I've uploaded an updated patch which revolves your comments.

Thanks,

Roman Bogorodskiy


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]