[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] apparmor: Allow access to filesystem mounts



Hi Felix,
On Thu, Jan 30, 2014 at 06:22:51PM +0100, Felix Geyer wrote:
> On 29.01.2014 07:48, Guido Günther wrote:
> > Hi,
> > On Sun, Jan 26, 2014 at 10:47:34PM +0100, Felix Geyer wrote:
> > [..snip..] `
> >> +    if (recursive) {
> >> +        // allow reading (but not creating) the dir
> >> +        virBufferAsprintf(buf, "  \"%s/\" r,\n", tmp);
> > Just a minor nit. Libvirt prefers /* */ style comments (see HACKING).
> > Cheers,
> >  -- Guido
> 
> Oops, do you want me to resubmit the patch?

Yes please but let's wait if other comments show up.
Cheers, 
 -- Guido


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]