[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCHv2 0/2] Fix problems with "forwardPlainNames"



changes from V1:

* Fix the test cases
* more information in commit log
* Add 2nd patch to make default forwardPlainNames='yes', as suggested
  by danpb (since that was the original behavior).

Here is the thread of the original patch:

   https://www.redhat.com/archives/libvir-list/2013-December/msg00397.html

(continued here in January):

   https://www.redhat.com/archives/libvir-list/2014-January/msg01521.html

I believe I've addressed Daniel's concerns except the ability to
prevent forwarding of unresolved names in the configured domain, but
that was never the intended behavior to begin with. These patches fix
the bugs in the currently advertised behavior; we can create followup
patches for this "new" behavior if there is demand (so far there have
only been people saying that behavior should be *removed* :-)


Laine Stump (2):
  network: only prevent forwarding of DNS requests for unqualified names
  network: change default of forwardPlainNames to 'yes'

 src/conf/network_conf.c                            | 32 +++++++++++++++-------
 src/conf/network_conf.h                            | 17 ++++++++++--
 src/network/bridge_driver.c                        | 17 +++++-------
 tests/networkxml2confdata/dhcp6-nat-network.conf   |  2 --
 tests/networkxml2confdata/dhcp6-network.conf       |  2 --
 .../dhcp6host-routed-network.conf                  |  2 --
 tests/networkxml2confdata/isolated-network.conf    |  2 --
 .../nat-network-dns-forwarders.conf                |  2 --
 .../networkxml2confdata/nat-network-dns-hosts.conf |  4 +--
 .../nat-network-dns-srv-record-minimal.conf        |  2 --
 .../nat-network-dns-srv-record.conf                |  2 --
 .../nat-network-dns-txt-record.conf                |  2 --
 tests/networkxml2confdata/nat-network.conf         |  2 --
 tests/networkxml2confdata/netboot-network.conf     |  2 --
 .../networkxml2confdata/netboot-proxy-network.conf |  2 --
 tests/networkxml2confdata/routed-network.conf      |  2 --
 tests/networkxml2xmlout/nat-network-dns-hosts.xml  |  2 +-
 .../nat-network-dns-more-hosts.xml                 |  2 +-
 .../nat-network-no-hosts.xml                       |  1 +
 19 files changed, 49 insertions(+), 50 deletions(-)

-- 
1.8.5.3


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]