[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v5 0/6] Support keyboard device



Is this patch series ready to be pushed? Without it, libvirt cannot create VMs in ppc64 hosts with a working VNC console (unless you use the qemu command line pass-through hack), this affects both oVirt and VDSM, since they rely on graphical terminals to work.



On Thu, Dec 19, 2013 at 5:50 AM, Li Zhang <zhlcindy gmail com> wrote:
From: Li Zhang <zhlcindy linux vnet ibm com>

This patchset is to add keyboard input device.

For PPC64, it doesn't support a default keyboard device when the graphic
is enabled. Libvirt supports QEMU command line as "-device VGA" which
won't create any keyboard device for it. So it requires libvirt to add
a default USB keyboard device for it.

This patchset is to add keyboard input device and a default USB keyboard
for PPC64.

The related discussion in QEMU community:
http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg01734.html

Li Zhang (6):
  conf: Add a keyboard input device type
  conf: Add one interface to add default input devices.
  conf: Remove PS2 mouse device for non-X86 platforms
  qemu_cap: Add USB keyboard capability
  qemu: parse qemu command line for USB keyboard
  Add a default USB keyboard and USB mouse for PPC64

 v5 -> v4:
   * Add PS/2 KBD definition in XML file. (Daniel.P.Berrange)
   * Allow PS/2 KBD devices and set KBD default bus as PS2 for X86, USB for non-x86. (Daniel.P.Berrange)
   * Add an implicit PS/2 KBD as PS/2 mouse. (Danniel.P.Berrange)

 v4 -> v3:
   * Don't remove PS2 mouse device for other virtualization drivers (Jan Tomko).

 v3 -> v2:
   * Handle the KBD device type in xen and QEMU driver. (Daniel.P.Berrange)
   * Remove PS2 mouse device for non-X86 platforms.
   * Move virDomainDefMaybeAddInput to a new patch. (Jan Tomko)
   * Replace VIR_REALLOC_N with VIR_APPEND_ELEMENT. (Jan Tomoko)
   * Fix several typos.                             (Jan Tomoko)
   * Add a virReportError when QEMU_CAPS_DEVICE_USB_KBD can't be gotten. (Jan Tomoko)

 v2 -> v1:
   * change ifs to switch clause.
   * reconstruct the patches

 docs/schemas/domaincommon.rng                      |  1 +
 src/conf/domain_conf.c                             | 92 ++++++++++++++--------
 src/conf/domain_conf.h                             |  5 ++
 src/libvirt_private.syms                           |  1 +
 src/qemu/qemu_capabilities.c                       |  2 +
 src/qemu/qemu_capabilities.h                       |  1 +
 src/qemu/qemu_command.c                            | 41 +++++++---
 src/qemu/qemu_domain.c                             | 23 +++++-
 src/util/virarch.h                                 |  2 +
 src/xenxs/xen_sxpr.c                               | 27 +++++--
 src/xenxs/xen_xm.c                                 | 30 +++++--
 tests/qemucapabilitiesdata/caps_1.2.2-1.caps       |  1 +
 tests/qemucapabilitiesdata/caps_1.3.1-1.caps       |  1 +
 tests/qemucapabilitiesdata/caps_1.4.2-1.caps       |  1 +
 tests/qemucapabilitiesdata/caps_1.5.3-1.caps       |  1 +
 tests/qemucapabilitiesdata/caps_1.6.0-1.caps       |  2 +
 tests/qemucapabilitiesdata/caps_1.6.50-1.caps      |  1 +
 tests/qemuhelptest.c                               |  8 ++
 .../qemuxml2argvdata/qemuxml2argv-pseries-disk.xml |  3 +-
 .../qemuxml2argv-pseries-usb-kbd.args              |  9 +++
 .../qemuxml2argv-pseries-usb-kbd.xml               | 19 +++++
 tests/qemuxml2argvtest.c                           |  3 +
 22 files changed, 212 insertions(+), 62 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-usb-kbd.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-usb-kbd.xml

--
1.8.2.1

--
libvir-list mailing list
libvir-list redhat com
https://www.redhat.com/mailman/listinfo/libvir-list


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]