[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] libxl: Resove Coverity dead_error_begin



On 01/31/2014 10:11 AM, John Ferlan wrote:

>>>  
>>> +        /* coverity[dead_error_begin] */
>>>          default:
>>>              break;
>>>          }
>>>
>>
>> Why not just delete the label instead; then you don't need a Coverity
>> marker?
>>
> 
> So are you advocating for removal of the other [dead_error_begin]
> conditions in the same manner?
> 
> see src/lxc/lxc_driver.c (3 occurrences) and src/nodeinfo.c (1 occurrence).

Sure - it's fewer lines of code, with no semantic difference, and with
no static checker warning.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]